search

makermadecnc / makerverse

GNU General Public License v3.0
31 stars 13 forks source link

Spindle not working #112

Open GDue opened 1 year ago

GDue commented 1 year ago

There is a problem with the manual widget control, which is always disabled. The reason is in the routine canClick() in the file .../Spindle/index.jsx.

canClick() {
    const { port, workflow } = this.state;

    if (!port) {
        return false;
    }
    if (workflow.state === WORKFLOW_STATE_RUNNING) {
        return false;
    }

    this.workspace.activeState.updateControllerState(this.state.controller.state);
    return this.workspace.activeState.canReceiveCommand;
}

This routine returns the property "canReceiveCommand" which is not existing in the "ActiveState"-Object. So this routine returns "null" which is not the "true" needed to enable the spindle widget.

Replacing the line with "return this.workspace.activeState.isReady;" is enabling the widget but I am not sure, whether "isReady" is the correct property to use here.

BR Gerhard

GDue commented 1 year ago

Forgot to mention.... I am refering to this version: commit 746224f947ad5c55745ccb96d2b50d6fa203a150 (HEAD -> master, tag: 1.1.6-login