search

makernexus / prusa-covid19-shield-remix

MakerNexus mods to Prusa Face Shield after consulting local healthcare providers
http://makernexuswiki.com/index.php?title=3D_printed_face_shields
16 stars 8 forks source link

Added replicate script #26

Closed esb7 closed 4 years ago

esb7 commented 4 years ago

Script has been updated since the version last night. It now includes separate left, right, from and back offset values and has a more reasonable output. There are a couple of vars at the top of the python file that can add more logging or change where the temp dir is created.

The script currently has to be run by invoking python3 directly.

esb7 commented 4 years ago

Looks like there are a bunch of unexpected commits. I'm going to close this and create a new branch / pull request that hopefully looks cleaner.

hzeller commented 4 years ago

no worries, I can squash-merge these all to one commit.

esb7 commented 4 years ago

I have a new branch with more changes. Let's use that. I'll open a PR

On Apr 11, 2020, at 12:00 PM, Henner Zeller notifications@github.com wrote:

Reopened #26 https://github.com/makernexus/prusa-covid19-shield-remix/pull/26.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/makernexus/prusa-covid19-shield-remix/pull/26#event-3224383181, or unsubscribe https://github.com/notifications/unsubscribe-auth/AM73TEQZ7VEJCKJCYIW2UPTRMC46PANCNFSM4MFXNMKA.

hzeller commented 4 years ago

Can you add a section in the README how to use the script, maybe with some examples ?

hzeller commented 4 years ago

oops, just merged this one, hopefully I now didn't create a mess for your new branch merge :/

esb7 commented 4 years ago

Sure. I'll look at that now.

On Apr 11, 2020, at 12:03 PM, Henner Zeller notifications@github.com wrote:

Can you add a section in the README how to use the script, maybe with some examples ?

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/makernexus/prusa-covid19-shield-remix/pull/26#issuecomment-612491797, or unsubscribe https://github.com/notifications/unsubscribe-auth/AM73TEWXHV6URFRBEL7C7FDRMC5J5ANCNFSM4MFXNMKA.