Develop

[jmg22]

hello i just to add some plugins to fixgw

-bmp085 -bno055 -button -mcp3008 -rotary_encoder -virtualwire

this is working but not finish.

a cleanup and some errors handling need to be done

[birkelbach]

I pulled this into my local branch to take a look at it. I made a few changes (just some merge conflicts) and pushed them into a new develop branch. I do have some comments...

This breaks Python 3 compatibility. It seems mostly tab/space issues at the moment, we should probably fix this before merging into the master branch.

Also it seems to me that the AeroCalc library should just be a dependency instead of being included in the source. Pip doesn't work with this library. Maybe we can get Kevin to fix that or we can fork it and get it working ourselves.

I think it also makes sense to prefix the names of the Raspberry Pi dependent modules with "rpi_" or something similar. There is no requirement that this program run on a RPi.

Thanks for the good work Jean.

[neil-d95]

Phil,

 I don't think there has been any development on AeroCalc since 

2008. While it would be better if it was a pip install over how I did it. Looks like it might be something in the how pip is trying to install cause it doesn't see a setup.py I think.

      What is broke for Python 3 I can take a look after I finish work stuff later today. I'm going to be looking at python code for most of the day any way.

Neil

On 12/28/2016 11:00 AM, Phil Birkelbach wrote:

I pulled this into my local branch to take a look at it. I made a few changes (just some merge conflicts) and pushed them into a new develop branch. I do have some comments...

This breaks Python 3 compatibility. It seems mostly tab/space issues at the moment, we should probably fix this before merging into the master branch.

Also it seems to me that the AeroCalc library should just be a dependency instead of being included in the source. Pip doesn't work with this library. Maybe we can get Kevin to fix that or we can fork it and get it working ourselves.

I think it also makes sense to prefix the names of the Raspberry Pi dependent modules with "rpi_" or something similar. There is no requirement that this program run on a RPi.

Thanks for the good work Jean.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/makerplane/FIX-Gateway/pull/13#issuecomment-269497254, or mute the thread https://github.com/notifications/unsubscribe-auth/AEjkWVdvEBaEK10rWDL2eqRj6B1YW_j0ks5rMoetgaJpZM4LWrPG.

[birkelbach]

Aerocalc installs with the setup.py file that comes in the distribution and it imports. I haven't tried any functions but it worked fine on my virtualenv with Python 2 and 3 so it's probably okay other than not being on pip. It installs easy enough. I couldn't find anywhere in this pull where it was being used anyway.

I'm not sure what were the issues with the new plugins. I tried to load them and got a bunch of errors about mixing tabs and spaces. Loaded them in Python 2 and they worked except for me not having any of the other modules that were needed. Didn't go any further than that. I won't be able to get them to load anyway because I'm out of town and not near my Raspberry Pi so I don't think the libraries that are required will load and work anyway.

[neil-d95]

Sounds like the formatting is wrong with those errors. I'll pull the develop and try to go through it.

Neil

Sent from my Verizon Wireless 4G LTE DROID

Phil Birkelbach notifications@github.com wrote:

Aerocalc installs with the setup.py file that comes in the distribution and it imports. I haven't tried any functions but it worked fine on my virtualenv with Python 2 and 3 so it's probably okay other than not being on pip. It installs easy enough. I couldn't find anywhere in this pull where it was being used anyway.

I'm not sure what were the issues with the new plugins. I tried to load them and got a bunch of errors about mixing tabs and spaces. Loaded them in Python 2 and they worked except for me not having any of the other modules that were needed. Didn't go any further than that. I won't be able to get them to load anyway because I'm out of town and not near my Raspberry Pi so I don't think the libraries that are required will load and work anyway.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/makerplane/FIX-Gateway","title":"makerplane/FIX-Gateway","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/makerplane/FIX-Gateway"}},"updates":{"snippets":[{"icon":"PERSON","message":"@birkelbach in #13: Aerocalc installs with the setup.py file that comes in the distribution and it imports. I haven't tried any functions but it worked fine on my virtualenv with Python 2 and 3 so it's probably okay other than not being on pip. It installs easy enough. I couldn't find anywhere in this pull where it was being used anyway.\r\n\r\nI'm not sure what were the issues with the new plugins. I tried to load them and got a bunch of errors about mixing tabs and spaces. Loaded them in Python 2 and they worked except for me not having any of the other modules that were needed. Didn't go any further than that. I won't be able to get them to load anyway because I'm out of town and not near my Raspberry Pi so I don't think the libraries that are required will load and work anyway."}],"action":{"name":"View Pull Request","url":"https://github.com/makerplane/FIX-Gateway/pull/13#issuecomment-269506160"}}}

[jmg22]

Hello,

i don’t use Aerocalc yet, i just put in fixgw for testing but honestly i think pyEfis is a better place. Unicode plain text give me some trouble (UTF-8), i’m working with a macbook with file sharing from the raspberry pi and i think this is maybe a problem for python( some time i need to use console with nano to adjust the tab).

« I think it also makes sense to prefix the names of the Raspberry Pi dependent modules with "rpi_" or something similar. There is no requirement that this program run on a RPi. » yes you are right, i will do.

sorry for my bad english and thank you for your great work

Jean-Manuel Gagnon

Le 28 déc. 2016 à 12:00, Phil Birkelbach notifications@github.com a écrit :

Aerocalc installs with the setup.py file that comes in the distribution and it imports. I haven't tried any functions but it worked fine on my virtualenv with Python 2 and 3 so it's probably okay other than not being on pip. It installs easy enough. I couldn't find anywhere in this pull where it was being used anyway.

I'm not sure what were the issues with the new plugins. I tried to load them and got a bunch of errors about mixing tabs and spaces. Loaded them in Python 2 and they worked except for me not having any of the other modules that were needed. Didn't go any further than that. I won't be able to get them to load anyway because I'm out of town and not near my Raspberry Pi so I don't think the libraries that are required will load and work anyway.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/makerplane/FIX-Gateway/pull/13#issuecomment-269506160, or mute the thread https://github.com/notifications/unsubscribe-auth/ADTlMOe6bxS9B2gUblZi5TH8mE6yY2Rgks5rMpW-gaJpZM4LWrPG.