search

makerplane / FIX-Gateway

Flight Information eXchange Gateway
GNU General Public License v2.0
9 stars 21 forks source link

Add DB mappings to more completely feed the EFIS display. #17

Closed Maker42 closed 5 years ago

birkelbach commented 5 years ago

Doesn't that need to be FUELQ1?

Maker42 commented 5 years ago

You'd think that. I sure did until I saw it didn't work. Having not closely examined key mappings and behaviors, I couldn't explain why.

On Thu, Oct 11, 2018 at 9:44 AM Phil Birkelbach notifications@github.com wrote:

Doesn't that need to be FUELQ1?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/makerplane/FIX-Gateway/pull/17#issuecomment-428978036, or mute the thread https://github.com/notifications/unsubscribe-auth/AYPbzYw8M4CVVygbwptoGBEH7gy-N2GTks5uj1lXgaJpZM4XXnUI .

birkelbach commented 5 years ago

Okay. I'm gonna go ahead and merge the changes, and then figure out why we have that discrepancy. I don't like that mapping method anyway. I'm probably going to change it to a configuration file of some kind.

Maker42 commented 5 years ago

Yes, I agree this mapping method needs to be re-examined. Maybe we don't need it at all because database.csv is already read from elsewhere and already contains said mappings, at least implicitly so.

On Thu, Oct 11, 2018 at 11:10 AM Phil Birkelbach notifications@github.com wrote:

Okay. I'm gonna go ahead and merge the changes, and then figure out why we have that discrepancy. I don't like that mapping method anyway. I'm probably going to change it to a configuration file of some kind.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/makerplane/FIX-Gateway/pull/17#issuecomment-429016944, or mute the thread https://github.com/notifications/unsubscribe-auth/AYPbzVjdaOWCqCfOYShTm0iVNa-Kz1hJks5uj22PgaJpZM4XXnUI .

birkelbach commented 5 years ago

The can-fix mappings need to be separate because it's entirely possible that a person could have multiple CAN-FIX busses that used different offsets. I'm going to open an issue for this. There is a bug in there somewhere anyway because this is not the expected behavior.