search

makerplane / pyEfis

Electronic Flight Information System in Python
GNU General Public License v2.0
58 stars 31 forks source link

Fix bug where airspeed tape would crash when aux data isn't available #88

Closed birkelbach closed 5 years ago

neil-d95 commented 5 years ago

Garrett,

    Is this the only one or are you going to have more?

On 7/12/19 10:44 PM, Garrett Herschleb wrote:

@Maker42 commented on this pull request.

In instruments/airspeed/init.py https://github.com/makerplane/pyEfis/pull/88#discussion_r303188809:

@@ -223,14 +222,17 @@ def init(self, parent=None):

      # V Speeds
      self.Vs = self.item.get_aux_value('Vs')
  • if self.Vs is None: self.Vs = 0

There's probably a ton of places that require aux data, and this is just one of them. It might be better to just bail out and give a nice error message instead of trying to work around and show a low utility display.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/makerplane/pyEfis/pull/88?email_source=notifications&email_token=ABEOIWO6MNVVXLC6MVPVDZTP7E6QTA5CNFSM4ICVGCY2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB6LITGY#pullrequestreview-261523867, or mute the thread https://github.com/notifications/unsubscribe-auth/ABEOIWKILZHDMFDP3WV6DZDP7E6QTANCNFSM4ICVGCYQ.

Maker42 commented 5 years ago

No, that's it. The peanut gallery rests. 😁

On Fri, Jul 12, 2019, 9:56 PM Neil Domalik notifications@github.com wrote:

Garrett,

Is this the only one or are you going to have more?

On 7/12/19 10:44 PM, Garrett Herschleb wrote:

@Maker42 commented on this pull request.

In instruments/airspeed/init.py https://github.com/makerplane/pyEfis/pull/88#discussion_r303188809:

@@ -223,14 +222,17 @@ def init(self, parent=None):

V Speeds

self.Vs = self.item.get_aux_value('Vs')

  • if self.Vs is None: self.Vs = 0

There's probably a ton of places that require aux data, and this is just one of them. It might be better to just bail out and give a nice error message instead of trying to work around and show a low utility display.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub < https://github.com/makerplane/pyEfis/pull/88?email_source=notifications&email_token=ABEOIWO6MNVVXLC6MVPVDZTP7E6QTA5CNFSM4ICVGCY2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB6LITGY#pullrequestreview-261523867>,

or mute the thread < https://github.com/notifications/unsubscribe-auth/ABEOIWKILZHDMFDP3WV6DZDP7E6QTANCNFSM4ICVGCYQ .

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/makerplane/pyEfis/pull/88?email_source=notifications&email_token=AGB5XTOALXY75T6UAI7Z2JTP7E75JA5CNFSM4ICVGCY2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZ3H3QY#issuecomment-511081923, or mute the thread https://github.com/notifications/unsubscribe-auth/AGB5XTL6QO3TILZGA3VS7QDP7E75JANCNFSM4ICVGCYQ .