alarm off ignored when pause/start cycle

makers-for-life / makair-firmware

🧠 [Software] Firmware for the MakAir microcontroller. The brain of the ventilator.

Other

20 stars 11 forks source link

alarm off ignored when pause/start cycle #63

Open pi-r-p opened 4 years ago

pi-r-p commented 4 years ago

Steps to reproduce:

start ventilation without anything connected
wait for the first level alarm
press alarm off
wait for the second level alarm
press alarm off
press pause twice to stop ventilation
start ventilation again : alarm off is not functionnal anymore.

Benhalor commented 4 years ago

I think it's a feature Reseting the snoozing state when paused seems OK to me. The only problem is that the green LED is not switching off when the machine is paused.