search

makers-for-life / makair-firmware

🧠 [Software] Firmware for the MakAir microcontroller. The brain of the ventilator.
Other
20 stars 11 forks source link

Dev #73

Closed Benhalor closed 3 years ago

Benhalor commented 3 years ago

Changelog

TODO:

Fix #55

dsferruzza commented 3 years ago

Several linter warnings remain:

srcs\eeprom.cpp:73:0: style: The function 'eeprom_read' is never used. [unusedFunction]
srcs\eeprom.cpp:129:0: style: The function 'eeprom_write' is never used. [unusedFunction]
srcs\telemetry.cpp:1276:0: style: The function 'sendBatteryDeeplyDischargedFatalError' is never used. [unusedFunction]
srcs\telemetry.cpp:1193:0: style: The function 'sendCalibrationFatalError' is never used. [unusedFunction]
srcs\telemetry.cpp:1360:0: style: The function 'sendInconsistentPressureFatalError' is never used. [unusedFunction]
srcs\telemetry.cpp:1322:0: style: The function 'sendMassFlowMeterFatalError' is never used. [unusedFunction]
srcs\telemetry.cpp:1155:0: style: The function 'sendWatchdogRestartFatalError' is never used. [unusedFunction]

@Benhalor @valeriansaliou These unused functions should be used before we release, right? (at least the non-eeprom ones?) Or is it too much WIP and we will ship these features later?