search

makers-for-life / makair

🫁 The world's first open-source ventilator tested on human patients. Mass-producible at a low cost (~2000€).
Other
814 stars 78 forks source link

[Soft] be sure that every pinMode(PIN_SERVO_PATIENT, OUTPUT); is OK #28

Closed waxzce closed 4 years ago

jabby commented 4 years ago

WIP here. https://github.com/covid-response-projects/covid-respirator/pull/21

dsferruzza commented 4 years ago

I believe this is already handled by the Servo lib we use? → https://github.com/arduino-libraries/Servo/blob/master/src/avr/Servo.cpp#L241

jabby commented 4 years ago

I close the issue as it is handled by Servo lib. Feel free to reopen if needed.

waxzce commented 4 years ago

but not for every pin, whiuch was my point

dsferruzza commented 4 years ago

I'm not sure to get your point actually... Both servos are OUTPUT thanks to the lib, right? Do we need more?

jtanguy commented 4 years ago

Yes, for the buttons, pressure sensor and buzzer. There is no pinMode set for any pin in the master branch atm

jabby commented 4 years ago

Ok I'm on it.

jabby commented 4 years ago