search

makersacademy / components

Components for building Makers Academy interfaces.
http://makersacademy.github.io/components
MIT License
3 stars 1 forks source link

40 one up component #56

Closed sjmog closed 9 years ago

sjmog commented 9 years ago

Not actually the one-up component: this is the more recent #55 . Some CSS to do but I am keen to get this merged so others have a record of the process.

Closes #55 .

leoallen85 commented 9 years ago

:+1: Looks good, my only concern is making the name of the block consistent before we merge it in

sjmog commented 9 years ago

Naming is hopefully more consistent now @pitchinvasion

leoallen85 commented 9 years ago

Argh please don't hate me but we can call it just slider rather than just slider-block - I want things as clear as possible for arfa et al and having the name as short as poss will help that

ducks

sjmog commented 9 years ago

YOU GOT IT

:imp:

sjmog commented 9 years ago

Naww, I knew it had to be done.

leoallen85 commented 9 years ago

:heart: thanks samm.

sjmog commented 9 years ago

^^

sjmog commented 9 years ago

@pitchinvasion I've just had a horrifying revelation that we might actually want to call this slider-block or something, b/c there are two kinds of sliders:

1) The full-screen one that can be used as a template 2) The smaller ones that go inside templates

uhoh