search

makersacademy / learn_to_program

For submitting exercises from the Chris Pine Learn to Program Book
11 stars 400 forks source link

Travis checks failed, even though program works #478

Closed calveym closed 8 years ago

calveym commented 8 years ago

https://github.com/makersacademy/learn_to_program/pull/477

There is the repo. Locally, it works, but travis CI says it does not. I think I have my output in a slightly different format to what it is expecting, as I know it works when I try the program from terminal. Does this 100% need to work, or should I move on?

hanrattyjen commented 8 years ago

Wondering the same thing! Chapter 9 exercise 1 (ask.rb) has passed but the two roman numerals exercises have failed even though they work from the command line. I even double checked some of my output against the Travis CI build output and they matched, yet showed as failed.

rspec also showed ask.rb and old_school_roman_numerals.rb as passing but wouldn't load roman_numerals.rb. Haven't figured out why yet.

If you haven't figured it out within the hour, I would do as the notes suggest and go onto the next exercise. I think I might do the same :)

ETA: Mine passed now. I had some extra 'puts' methods in there that were unnecessary. Removed in favour of: return "string", so it exits from the loop.

anitacanita commented 8 years ago

@LMCMLJ and @hanrattyjen Please move this issue to the pre_course repo, otherwise it doesn't show on slack!