search

makersacademy / problem-solving

For problem-solving during the PreCourse
6 stars 2 forks source link

'1 failing test' in pull request reporting progressto Chief #112

Closed oliverpople closed 7 years ago

oliverpople commented 7 years ago

Hi Guys, to finish step 6 in the challenge I sent a pull request to makersacademy/clmystery. Here is the link to that pull request:

https://github.com/makersacademy/clmystery/pull/669

It's says that 'All checks have failed: 1 failing check'. Further details to the failed check can be found at:

https://travis-ci.org/makersacademy/clmystery/builds/271142595?utm_source=github_status&utm_medium=notification

Anyone idea where i've gone wrong here? Thanks

haletothewood commented 7 years ago

It might be because your possible_witnesses.txt file is empty?

haletothewood commented 7 years ago

You also don't seem to have a suspects.txt file which is the step before submitting a pull request in step6.

haletothewood commented 7 years ago

Also, just realised I think the final check only works once you've completed step9. The pull request will fail until then. I think.