makerspace / makeradmin

Stockholm Makerspace member administration and store.
20 stars 14 forks source link

Rearrange product accounting table #401

Closed BerglundDaniel closed 8 months ago

BerglundDaniel commented 8 months ago

Summary by CodeRabbit

coderabbitai[bot] commented 8 months ago

Walkthrough

The overall change involves a transition from using separate debits and credits fields to a unified fraction field with an accompanying type field to indicate whether the entry is a debit or a credit. This refactoring affects the way product account cost centers are represented in the database and initialized in the code, streamlining the accounting process by consolidating the two fields into one with a type indicator.

Changes

File Path Change Summary
api/src/firstrun.py Altered create_shop_accounts_cost_centers function to initialize ProductAccountsCostCenters with fraction and type instead of debits and credits.
api/src/.../0024_account_cost_center.sql Modified webshop_product_accounting table schema, replacing debits and credits with fraction (numeric) and type (enum).
api/src/shop/models.py Updated ProductAccountsCostCenters class, replacing debits and credits with fraction (numeric) and type (enum), and adding constants DEBIT and CREDIT.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on X ?


Tips ### Chat with CodeRabbit Bot (`@coderabbitai`) - You can directly reply to a review comment made by CodeRabbit. Example: - _I pushed a fix in commit ``._ - You can tag CodeRabbit on specific lines of code or entire files in the PR by tagging `@coderabbitai` in a comment. Examples: - _@coderabbitai generate unit tests for this file_ - _@coderabbitai modularize this function_ - You can tag `@coderabbitai` in a PR comment and ask questions about the PR and the codebase. Use quoted replies to pass the context for follow-up questions. Examples: - _@coderabbitai render interesting statistics about this repository as a table_. - _@coderabbitai show all the `console.log` statements in this repository_. - _@coderabbitai generate unit tests for the `src/utils.ts` file_. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger a review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - The JSON schema for the configuration file is available [here](https://coderabbit.ai/integrations/coderabbit-overrides.v2.json). - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json` ### CodeRabbit Discord Community Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback.