makerspace / makeradmin

Stockholm Makerspace member administration and store.
20 stars 14 forks source link

Run stripe tests in CI #410

Open emanuelen5 opened 8 months ago

coderabbitai[bot] commented 8 months ago

[!IMPORTANT]

Auto Review Skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository.

To trigger a single review, invoke the @coderabbitai review command.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger a review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
emanuelen5 commented 8 months ago

@coderabbitai Make sure that the .env file is read before running the Stripe tests, so they are not skipped

coderabbitai[bot] commented 8 months ago

@emanuelen5 It appears that there are no direct references to dotenv or similar environment variable management libraries in the JavaScript or TypeScript files within the repository. This could mean that the .env file is either being loaded in a non-standard way or it's managed by another process not visible in the repository's codebase.

Since the standard approach with dotenv is not used, the loading of environment variables might be handled by the test runner configuration or through another setup mechanism that isn't immediately apparent from the repository's code.

If the Stripe tests are being skipped due to missing environment variables, you might want to ensure that the test runner or CI/CD pipeline is configured to load the .env file before the tests start. This could involve adding a step to your CI/CD configuration or a pre-test script in your package.json.

If you have a specific setup or test file that should be handling this, please point me to it, and I can look into that file directly. Otherwise, you may need to manually check your test runner or CI/CD pipeline settings.

Analysis chain @emanuelen5 To ensure that the `.env` file is being read before the Stripe tests are executed, I'll need to check the test setup scripts or configuration files where environment variables are typically loaded. I'll generate a script to locate and display the contents of the test setup files or any relevant configuration files that might be responsible for loading the `.env` file. --- The output from the script does not explicitly show the loading of a `.env` file before the execution of tests. However, it's common for environment variables to be loaded within test scripts or setup files in Node.js projects using libraries like `dotenv`. Since the output includes various configuration and setup files, but none of them seem to include code for loading `.env` files, we may need to look for a specific test setup file or a script that is run before the tests. To proceed, I'll generate a script to search for any occurrences of `dotenv` or similar environment variable management in the JavaScript and TypeScript files, which would indicate where the `.env` file is being loaded.
Scripts executed The following scripts were executed for the analysis: --- Script: ```shell #!/bin/bash # Find files that are likely to be responsible for loading .env files fd --type f --extension sh --extension js --extension json "test|setup|config" | xargs cat ``` Length of output: 16335 --- --- Script: ```shell #!/bin/bash # Search for dotenv or similar environment variable management usage rg --type js --type ts "require\(['\"]dotenv['\"]\)|import ['\"]dotenv['\"]" ``` Length of output: 86
emanuelen5 commented 8 months ago

All of the subscription tests pass now. The following test still fail, though

test-1              | FAILED shop/test/stripe_payment_intent_test.py::StripePaymentIntentTest::test_pay_with_stripe_fail
test-1              | FAILED shop/test/stripe_payment_intent_test.py::StripePaymentIntentTest::test_pay_with_stripe_success
test-1              | FAILED shop/test/stripe_payment_intent_test.py::StripePaymentIntentTest::test_get_payment_intent_with_declined_card
test-1              | FAILED shop/test/stripe_payment_intent_test.py::StripePaymentIntentTest::test_get_payment_intent_few
test-1              | FAILED systest/api/purchase_test.py::Test::test_purchase_from_existing_member_using_auto_validating_3ds_card_works
emanuelen5 commented 7 months ago

^ Rebased onto origin/master