Closed BerglundDaniel closed 7 months ago
The recent updates involve a shift away from using the Optional
type in the typing
module across various accounting-related files in the API. Logging statements have been removed from initialization and specific functions within the accounting logic to possibly streamline performance and reduce clutter. Additionally, the testing for the SIE file format has been enhanced with more detailed assertions, improving the robustness of the tests.
Files | Change Summary |
---|---|
.../accounting/accounting.py , .../accounting/test/accounting_test.py .../accounting/export.py , .../accounting/test/export_test.py .../accounting/sie_file.py , .../accounting/test/sie_file_test.py .../accounting/verification.py , .../accounting/test/verification_test.py |
Removed Optional from imports; eliminated logging from __init__ , split_transaction_fee_over_transaction_contents , and split_transactions_over_accounts in accounting.py ; modified import to remove Optional type in export.py ; removed Optional import, modified Tuple import; removed logging from transaction_string and updated test_get_sie_string with new processing logic and assertions in sie_file.py ; removed Optional import, retained Tuple import in verification.py . |
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Summary by CodeRabbit