Closed BerglundDaniel closed 6 months ago
The recent updates focus on enhancing the system's accounting features. Key improvements include the ability to export transaction history as SIE files, refined logic for allocating transaction fees across products based on quantity and total price, and precise handling of rounding errors. The code now uses the Decimal data type for financial calculations to ensure accuracy. Additionally, obsolete functions related to rounding error conversions have been removed, and the test suite has been updated to align with the new logic.
File Path | Change Summary |
---|---|
README.md |
Introduced SIE file export support; refined product price adjustment logic to distribute transaction fees considering quantity and price, with rounding error corrections. |
.../accounting/accounting.py |
Updated functions for transaction/payment discrepancies, fee distribution, and account splitting; improved accuracy with Decimal and error handling. |
.../accounting/export.py |
Removed functions and logs related to rounding error transactions. |
.../accounting/test/accounting_test.py |
Updated tests for new logic in fee splitting and account transactions; added tests for odd fees and fractions; removed pytest import. |
.../accounting/test/export_test.py |
Removed tests for the now-deleted rounding error transaction function. |
.../accounting/verification.py |
Minor updates with added whitespace and TODO for future verification tests. |
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Summary by CodeRabbit
New Features
Improvements
Bug Fixes
product_accounting
could cause unexpected behavior by adding necessary checks.Tests
Documentation
Chores