search

makerspace / makeradmin

Stockholm Makerspace member administration and store.
20 stars 14 forks source link

Modifications to the automatic email sent to new members. #469

Open nperozzi opened 5 months ago

nperozzi commented 5 months ago

Hi, I am submitting a new version of the automatic email sent to new members when their membership is approved. The email is a complement to the Member Introduction Guide. It expands on some topics, repeats others, and complements with links to further info.

Summary by CodeRabbit

coderabbitai[bot] commented 5 months ago

Walkthrough

The updates encompass two main areas: a refinement in the VS Code settings to enhance import organization by switching from a boolean to a more descriptive string value, and comprehensive enhancements to the new_member.body.html template. These enhancements include the incorporation of meta and style elements, content restructuring and expansion in both Swedish and English, and detailed updates aimed at clarifying member information, rules, and responsibilities, alongside formatting improvements.

Changes

File Summary of Changes
.vscode/settings.json Changed source.organizeImports from true to "explicit" to refine import organization.
api/src/.../new_member.body.html Added meta charset and style block; restructured and rephrased content; introduced new sections; updated member information presentation; clarified rules, responsibilities, and resources; made formatting improvements.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with CodeRabbit: - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit-tests for this file.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit tests for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository from git and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit tests.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger a review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - The JSON schema for the configuration file is available [here](https://coderabbit.ai/integrations/coderabbit-overrides.v2.json). - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json` ### CodeRabbit Discord Community Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback.
HalfVoxel commented 5 months ago

Would you mind sending a test email to us (ideally also the previous email as a comparison)? It's a bit hard to get a feeling for the impression by just reading the HTML code.

emanuelen5 commented 5 months ago

Here is the email from before the changes. We didn't send a new one afterwards. Can do that after the next review round.

Let's see if Github can format the email as well... :)

SVENSKA

Hejsan! VĂ€lkommen till Stockholm Makerspace! 😃 Vi hoppas du uppskattade introkursen och Ă€r redo att pĂ„börja din kreativa resa med oss.

Som ny medlem har du förmodligen en del frÄgor. I detta mail kommer du fÄ en sammanfattning av vad du fick höra pÄ introkursen och lÀnkar till nÄgra onlineresurser som hjÀlper dig att komma igÄng. Dina medlemsuppgifter:

Namn: first1 last1 Epost: @.*** Medlemsnummer: 1001

Vi kommer anvÀnda denna epostadress för att nÄ ut till dig. Om detta inte stÀmmer, vÀnligen kontakta @.***

HÀr kommer en sammanfattning av huvudpunkterna frÄn introkursen: Om Stockholm Makerspace:

Stockholm Makerspace Ă€r en ideell förening som drivs “av medlemmar för medlemmar”. Detta innebĂ€r att du, som föreningsmedlem, uppmuntras att delta i föreningens drift och utveckling. Kom igĂ„ng:

Först och frÀmst, se till att du har allt du behöver för att komma igÄng:

Trivselregler

“Visa hĂ€nsyn. Ta ansvar.”

Visa hÀnsyn mot andra medlemmar:

Ta ansvar för...

För mer information om reglerna nÀr du besöker makerspacet, lÀs wikisidan med vÄra Lokalregler https://wiki.makerspace.se/Lokalregler. StÀdning, underhÄll, ordning och reda:

NÄgra anvÀndbara lÀnkar:

-

Söker du nÄgon i styrelsen? Du hittar alla namn pÄ Styrelse wikisida https://wiki.makerspace.se/Styrelsen, eller sÄ kan du skicka ett mail till @.***

Vi glÀdjer oss att ha dig som medlem i Stockholm Makerspace! Om du har nÄgra frÄgor som wikin inte kan svara pÄ, tveka inte att skriva pÄ Slack. Det finns alltid andra medlemmar som vill hjÀlpa dig.

BÀsta skaparhÀlsningar! Stockholm Makerspace www.makerspace.se

ENGLISH

Hi there! Welcome to Stockholm Makerspace! 😃 We hope you enjoyed the Intro Course and are excited to embark on your creative journey with us.

As a new member, you probably have a lot of questions. In this email we provide you with a summary of what you heard on the introduction course and a few resources to get you started. Your member information:

Name: first1 last1 Email: @.*** Membership number: 1001

We will use this email address to reach out to you. If this is not correct, please email @.***

Here's a summary of the key points covered during the course: About Stockholm Makerspace:

Stockholm Makerspace is a non-profit organization “for members, by members”. This means that you too, as a member, are encouraged to participate and collaborate with the development of the organization. Getting Started:

First of all, make sure you have all you need to get started:

Expected conduct at the space

“Be considerate. Take responsibility.”

Be considerate towards other members:

Be responsible for...

For more information on the space rules read the Local Rules wiki page https://wiki.makerspace.se/Lokalregler. Order, cleaning, and maintenance:

Some references:

-

Are you looking for somebody on the board? You will find their names at Styrelse wiki https://wiki.makerspace.se/Styrelsen, or you can write an email to @.***

We're thrilled to have you as a member of Stockholm Makerspace. If you have questions that cannot be answered with the information on the wiki, please post on Slack! There will always be other members happy to help you out.

Happy Making! Stockholm Makerspace www.makerspace.se

nperozzi commented 5 months ago

Hi guys! 🖐 I believe I fixed all the comments. What is the next step of this process?

Other related topics: 1) The trigger for this email should be when the Intro Course host presses "Save" or "Save and send Accessy" buttons after people sign the makerspace agreement. Currently, the automation (not sure how we call the py script that does this), sends this email when the first payment is confirmed, which happens before the Intro Course. 2) We still need an email to be sent when people make their first payment. As per discussions during the last project evening, this email should be short and include just these points (or something like it):

HalfVoxel commented 2 months ago

If it would be possible for you to send a test email to all reviewers, that would be great. It would be great if this could be sent to our actual email addresses, to get a feel for how it flows in an actual email client.