search

makerspace / makeradmin

Stockholm Makerspace member administration and store.
https://docs.makeradmin.se/
21 stars 16 forks source link

Fix a docker warning by removing version from docker files #507

Closed BerglundDaniel closed 7 months ago

BerglundDaniel commented 7 months ago

Docker version later than 2.25 warns about version being obsolete. We probably need to update the docker version on the server before deploying this change

Summary by CodeRabbit

coderabbitai[bot] commented 7 months ago

Walkthrough

The recent updates to the Docker Compose files involve removing the version specification and making format adjustments. Specifically, the db2 service's port and volume configurations have been refined across different environment setups. Additionally, the default image for the db2 service in the main Docker Compose file has been updated to mysql:8.0.33.

Changes

Files Change Summary
docker-compose.dev.yml Removed version declaration, adjusted indentation for db2 service ports.
docker-compose.prod.yml Removed version declaration, adjusted indentation for db2 service volumes.
docker-compose.test.yml, docker-compose.yml Removed version declaration. docker-compose.yml sets db2 image to mysql:8.0.33.
Recent Review Details **Configuration used: CodeRabbit UI** **Review profile: CHILL**
Commits Files that changed from the base of the PR and between e08b6d36485ae3deb06e30a9234994b82f2aaa65 and 935131bc861fdbb9732061e0a4f1bafab123de20.
Files selected for processing (5) * docker-compose.dev.yml (1 hunks) * docker-compose.override.yml (1 hunks) * docker-compose.prod.yml (1 hunks) * docker-compose.test.yml (1 hunks) * docker-compose.yml (1 hunks)
Files skipped from review due to trivial changes (2) * docker-compose.dev.yml * docker-compose.prod.yml
Additional comments not posted (2)
docker-compose.test.yml (1)
`1-3`: > :memo: **NOTE** > This review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [1-31] The removal of the version declaration and the adjustments in the indentation are correctly implemented. Please ensure to test the configurations in a test environment to verify that all services are functioning as expected.
docker-compose.yml (1)
`1-3`: > :memo: **NOTE** > This review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [1-63] The removal of the version declaration and the update to the `db2` service image to `mysql:8.0.33` are correctly implemented. Please ensure to test the MySQL service specifically to verify compatibility with the lumen library as described in the comments.
--- Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger a review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
BerglundDaniel commented 7 months ago

Docker is removing it from the spec so it doesn't do anything in later versions. It's a bit weird though because telling docker what version the xml is using seems like a good thing to have so I don't get it why they removed it.

https://github.com/docker/compose/issues/11628