search

makerspace / memberbooth

Displaying member info on a public machine
2 stars 0 forks source link

55 51 56 gui and label fixes #58

Closed InMyOrbit closed 4 years ago

InMyOrbit commented 4 years ago

Solved issues #51, #55 & #56.

Plus added input check on temporary storage label text.

emanuelen5 commented 4 years ago

Looks good, just want to test run

emanuelen5 commented 4 years ago

I test ran and found/fixed a bug (that appeared after previous merge with master). I however have two observations when creating labels for firebox and temporary storage (FYI, I created the labels 2020-03-15):

Label for firebox

image

Change suggestions

  1. I think it should say

    any member can use this product from <date>

    to make it clearer when the end date is.

  2. There should be a title and/or icon on the label so that it cannot be used as/confused with a temporary storage label.

Label for temporary storage

image

Question

The date is set to only today + 30 days: Shouldn't this be 90 days?