search

makerspace / memberbooth

Displaying member info on a public machine
2 stars 0 forks source link

Label creator refactoring #69

Closed InMyOrbit closed 4 years ago

emanuelen5 commented 4 years ago

This is gonna seem super-pedantic... I think you should revert the last commit (8de32ab552abf8d33c9829c4a48eea84020b68e7) to the commit before the merge with master (8d8f10f9a962fbecac6e45891fd17b69e6e13fea). The branches had no conflict, so it is not necessary.

emanuelen5 commented 4 years ago

Otherwise it seems really nice. Improvements:

  1. It is now much faster to create labels.
  2. Much less code => also 34 less flake8 warnings! :)