Adding flake8 style test

makerspace / memberbooth

Displaying member info on a public machine

2 stars 0 forks source link

Adding flake8 style test #78

Closed emanuelen5 closed 4 years ago

emanuelen5 commented 4 years ago

Also corrected the errors that were reported when running the flake8 test. Ignore for:

W501 (Too long lines) - Since every normal editor can line wrap automatically

InMyOrbit commented 4 years ago

Perhaps we should add flake8 test on a pre-commit hook so that you don't have to clean up every now and then.

emanuelen5 commented 4 years ago

Sure, you can do that. However, pre-commit hooks must be set up per project (after clone), i.e. they cannot be cloned. I think it is better that they are run by the CI-service, and that we use pull-requests for merging features. That way we just have to make sure to check the status of the build before merging.