search

makerspace / memberbooth

Displaying member info on a public machine
2 stars 0 forks source link

Logs are hard to read #81

Closed emanuelen5 closed 4 years ago

emanuelen5 commented 4 years ago

There are several issues:

  1. This is printed every minute when there is no activity 
    2020-10-06 00:25:55,084 INFO [/home/memberbooth/memberbooth/src/gui/states.py:40]: Event: gui_event_timeout_timer_expired, without data
  2. This is printed every time the mouse/keyboard is used (can be several times a second while in use): 
    2020-10-05 23:12:47,762 INFO [/home/memberbooth/memberbooth/src/gui/design.py:87]: Timeout timer was reset
  3. State transitions are hard to follow from the log (this shows when a member prints a label): 
    2020-10-05 23:12:47,972 INFO [/home/memberbooth/memberbooth/src/gui/states.py:40]: Event: gui_event_print_storage_label, with data
InMyOrbit commented 4 years ago

Things that we talked about fixing a year ago but never did...

1 & 2 - Straight forward. 3 - We should aim to have event and the transition in the logs, I agree.

InMyOrbit commented 4 years ago

Fixed 1&2 in 65689c54d31cd55869f6a04125563bff9e879b02.

Looking at 3 I think that is expected behavior, there is no state transition during the mentioned event, the state transition happens when the printing is finished. So the event mentioned is a signal from the gui to the application which then initiates the print and then causes a state transition based on the printing result.

emanuelen5 commented 4 years ago

Closed in fdb496a