makesign / concerto2

New Rails 7 version of concerto - WIP WORK IN PROGRESS!
0 stars 0 forks source link

fix remaining 61 failing tests #18

Open bkleinen opened 1 month ago

bkleinen commented 1 month ago

ContentTest#test_is_denied?_detects_if_content_denied_on_any_feed [test/unit/content_test.rb:152]: ContentTest#test_is_pending?_detects_if_content_pending_on_any_feed [test/unit/content_test.rb:182]: ContentTest#test_is_orphan?_identifies_content_without_submissions [test/unit/content_test.rb:140]: ContentTest#test_filter_content_by_screen [test/unit/content_test.rb:243]: ContentTest#test_is_approved?_true_only_when_content_is_approved_on_all_feeds [test/unit/content_test.rb:212]: ContentTest#test_filter_content_by_feed [test/unit/content_test.rb:248]: ContentTest#test_content_type_scope_works [test/unit/content_test.rb:102]: ContentTest#test_user_cannot_unassociated [test/unit/content_test.rb:46]:

Frontend::ContentsControllerTest#test_0x0_image_gracefull_fails: Frontend::ContentsControllerTest#test_should_get_content_for_field [test/functional/frontend/contents_controller_test.rb:19]:

ClientTimeTest#test_validations [test/unit/client_time_test.rb:16]:

SubmissionsControllerTest#test_moderators_can_reorder_feed_items: SubmissionsControllerTest#test_reordered_items_must_be_on_same_feed: SubmissionsControllerTest#test_reordered_items_must_be_active: SubmissionsControllerTest#test_reordered_items_must_be_approved: ShuffleIntegrationTest#test_returns_expected_content_in_expected_order [test/integration/base_shuffle_test.rb:17]: ScreensControllerTest#test_signed_in_user_has_personal_screens [test/functional/screens_controller_test.rb:24]: PriorityShuffleIntegrationTest#test_returns_level_1_priority_content: PriorityShuffleIntegrationTest#test_returns_level_2_priority_content: WeightedShuffleIntegrationTest#test_returns_expected_content [test/integration/weighted_shuffle_test.rb:19]: SubmissionFixtureTest#test_valid_fixtures [test/models/submission_test.rb:16]: SubmissionTest#test_submission_requires_content [test/models/submission_test.rb:54]: SubmissionTest#test_submission_requires_feed [test/models/submission_test.rb:45]: SubmissionTest#test_deny_expired_pending_content [test/models/submission_test.rb:147]: SubmissionTest#test_parent_propogates_moderation [test/models/submission_test.rb:105]: SubmissionTest#test_submissions_must_be_unique [test/models/submission_test.rb:64]:

ContentsControllerTest#test_render_single_dimension_resize_content: ContentsControllerTest#test_render_resized_content_preview: ContentsControllerTest#test_user_cannot_submit_to_all_feeds [test/functional/contents_controller_test.rb:101]: ContentsControllerTest#test_should_demoderate_submissions_on_edit: ContentsControllerTest#test_render_cropped_content_preview: ContentsControllerTest#test_should_upload_new_ticker: ContentsControllerTest#test_render_full_content_preview:

TemplatesControllerTest#test_should_destroy_template [test/functional/templates_controller_test.rb:142]: TemplatesControllerTest#test_renderresized(fixed_width)_template_preview: TemplatesControllerTest#test_render_full_template_preview: TemplatesControllerTest#test_renderresized(fixed_height)_template_preview: TemplatesControllerTest#test_update_a_template's_media:

Frontend::ScreensControllerTest#test_screen_setup_makes_sense: ConcertoConfigTest#test_set_and_get_with_cache [test/unit/concerto_config_test.rb:36]: GraphicTest#test_graphics_require_a_file: GraphicTest#test_render_details_includes_path: GraphicTest#test_graphics_must_be_images:

ScreenUnitTest#test_a_screen_has_positions [test/unit/screen_test.rb:89]: ScreenUnitTest#test_name_cannot_be_blank [test/unit/screen_test.rb:25]: ScreenUnitTest#test_a_screen_has_fields [test/unit/screen_test.rb:97]:

VersionCheckTest#test_latest_version_is_cached_for_24_hours [test/unit/version_check_test.rb:27]:

ConcertoImageMagickTest#test_resize_with_options: ConcertoImageMagickTest#test_graphic_transform_supports_cropping: ConcertoImageMagickTest#test_load_returns_an_image [test/unit/image_magick_test.rb:18]: ConcertoImageMagickTest#test_image_info_returns_info_about_image: ConcertoImageMagickTest#test_crop_image: ConcertoImageMagickTest#test_resize_resizes_image: ConcertoImageMagickTest#test_resize_with_invalid_options_returns_empty_image:

Frontend::TemplatesControllerTest#test_0x0_template_fails_gracefully: Frontend::TemplatesControllerTest#test_no_size_templates_are_ok:

DynamicContentTest#test_refresh_failure_sets_last_bad_refresh [test/unit/dynamic_content_test.rb:77]: DynamicContentTest#test_refresh_success_sets_last_ok_refresh [test/unit/dynamic_content_test.rb:90]: DynamicContentTest#test_Auto_save_and_load: DynamicContentTest#test_manual_refresh [test/unit/dynamic_content_test.rb:168]: DynamicContentTest#test_refresh_class_method_refreshes_the_content:

bkleinen commented 1 month ago

see https://github.com/makesign/concerto2/blob/main/doc/fix-tests-anleitung.md

bkleinen commented 1 month ago

These tests are probably related to the Attachments, thus moving them to the fix attachments Issue https://github.com/makesign/concerto2/issues/26

ConcertoImageMagickTest#test_resize_with_options: ConcertoImageMagickTest#test_graphic_transform_supports_cropping: ConcertoImageMagickTest#test_load_returns_an_image [test/unit/image_magick_test.rb:18]: ConcertoImageMagickTest#test_image_info_returns_info_about_image: ConcertoImageMagickTest#test_crop_image: ConcertoImageMagickTest#test_resize_resizes_image: ConcertoImageMagickTest#test_resize_with_invalid_options_returns_empty_image:

Frontend::ContentsControllerTest#test_0x0_image_gracefull_fails: Frontend::ContentsControllerTest#test_should_get_content_for_field [test/functional/frontend/contents_controller_test.rb:19]:

GraphicTest#test_graphics_require_a_file: GraphicTest#test_render_details_includes_path: GraphicTest#test_graphics_must_be_images: