search

makesites / cloudvisio

Data visualizations of cloud data - built on top of D3 #javascript #d3 #html5 #css3
https://npmjs.org/package/cloudvisio
5 stars 1 forks source link

Charts should check their requirements are met #12

Closed tracend closed 11 years ago

tracend commented 11 years ago

Each chart has options, amongst them for setting the label, that need to be satisfied before te chart is rendered.

Instead if expecting these options to be available when the rendering starts, it is better to fallback if they are not set...

tracend commented 11 years ago

Consider renaming the options.chart to options.axis or options.attributes - or even placing this object out of the options in an internal _axis

tracend commented 11 years ago

Closing as addressed