search

makeup / makeup-js

Mono-repo for all vanilla JavaScript utility modules and headless ui
https://makeup.github.io/makeup-js
42 stars 10 forks source link

Keyboard-Trap: Chrome/Talkback swipes to keyboard trap boundary elements #8

Closed ianmcburnie closed 4 years ago

ianmcburnie commented 4 years ago

Chrome/Talkback is including the keyboard trap boundary in its swipable elements, even though they contain no content. A quick test showed that the addition of aria-hidden="true" solved this, but I need to make sure it doesn't cause issues for other screen readers.

ianmcburnie commented 4 years ago

Fixed in makeup-keyboard-trap@0.2.5 with aria-hidden="true" applied to boundary elements