makeusabrew / decking

A Docker helper to create, manage and run clusters of containers
http://decking.io
443 stars 36 forks source link

Image naming #67

Closed sassrobi closed 10 years ago

sassrobi commented 10 years ago

Hi! I'm using decking from npm (v0.2.1) with docker (v1.0.1), and i found a strange behaviour. In my decking.json i got this image declaration:

"images":{
    "identity-postgres":"./identity-postgres"
},
(etc...)

i've got a valid Dockerfile in identity-postgres folder. When i run decking build all it builds the image, but isn't give it a name nor a tag.

REPOSITORY                              TAG                 IMAGE ID
<none>                                  <none>              ba303aaec020

It's not working even if i try it with exact name (decking build identity-postgres) Because of this, it cannot intstantiate a container from it in decking create phase...

What am i doing wrong? Thanks!

ps. sorry for my bad english

stephenmelrose commented 10 years ago

This is an issue with Docker v1.0.x. The build is actually failing, and the API decking uses returns a 200 instead of an error. Manually do a docker build and see what the error is. Remember, decking copies the Dockerfile to the root where the decking file is for execution.

stephenmelrose commented 10 years ago

I also think someone fixed this so decking handles it, although this hasn't been released yet. Maybe try installing from master?

sassrobi commented 10 years ago

Thanks, but no, the build is not failing with docker build. It creates a fully functioning image, even decking can use it (create, start). By the way, the Dockerfile contains an ADD line. Do decking copies this file to its root too? I will try installing from master, maybe it helps

Edit: ohh i found it in documentation: "such that any ADD directives will be relative to your project root."

sassrobi commented 10 years ago

that was the problem, thanks