Closed ahmedomarjee closed 9 years ago
Sorry; only just seen this. I'm going to need some time to review it but in the meantime if you could ensure it doesn't alter any indentation (2 spaces) or replace any spaces with tabs that'd make for a slightly neater diff.
Also, while I appreciate from the looks of it you may already be using it internally, please don't bump the patch version in package.json.
Thanks!
Nick
I have updated the code style and downgraded the package version.
I also merged in the pull request provided by https://github.com/neo21670 at https://github.com/ahmedomarjee/decking/pull/1 which contained:
Please review.
+1
Sorry for taking so long to merge this. I'm not sure of Decking's place in the ecosystem now Docker themselves are branching out so aggressively into orchestration; but anyway in the meantime, thanks - merged :)
Thank you, i know that docker team is developing orchestration but what you've done is really simple to use and maintain.
Docker tools will be very cool but im not sure that it will be so simple that yours. We gonna contribute soon to add more feature to decking. So please continue, it will be a great orchestration tools.
Greetings
Yann Schepens (from Nantes, France) Le 9 janv. 2015 19:17, "Nick Payne" notifications@github.com a écrit :
Merged #69 https://github.com/makeusabrew/decking/pull/69.
— Reply to this email directly or view it on GitHub https://github.com/makeusabrew/decking/pull/69#event-216660022.
The pull requests consists of the following :
Example
So instead of:
we can also use:
Notes