makevoid / guard-concat

This little guard plugin allows you to concatenate js/css (or other) files in one.
Other
12 stars 6 forks source link

minor refactor & allow compiling on start #5

Closed mikz closed 9 years ago

mikz commented 11 years ago

Hi! I wanted to add compiling on start of guard. So first I've added bundler support to install dependencies and extracted some magic variables to methods. Then i've added :all_on_start option (same as guard-coffee) to concat all files on start of guard.

Cheers!

makevoid commented 11 years ago

Thanks for the pull request

I saw you added bundler to release the gem, why? Are there any benefits by using that instead of normal gem build? You had to modify the gemspec: https://github.com/mikz/guard-concat/commit/b4232675c91a675de369dc0f1b62dd532445381d#L3R2 I prefer how it was before :D

Also the changes in .gitignore should be dropped

For the rest it's a good patch, change it or tell me why not to change it and I will accept it Thanks!

mikz commented 11 years ago

I've added bundler because rake install is easier than building and installing. But if you prefer plain gem, I'll remove it. The rescues in gitignore are there because normally version is in different file then the rest of the code so loading just that file does not require dependencies. Unfortunately this does not work exactly right as Guard::Concat is a class (and inheritig from guard) instead of a module. So the rescue basically allows you to run bundle to install dependencies after checking out the project. I'll split the changes to multiple commits so you can cherry-pick just the stuff you want.

mikz commented 11 years ago

Feel free to cherry-pick just what you want. The changes in .gitignore are for RubyMine IDE, compiled gems just in root folder and ruby-version file as everybody can use different patch level or even ruby version.

cantino commented 11 years ago

:+1:

makevoid commented 9 years ago

this is now merged in master and deployed to rubygems, thanks again for your contribution!