makew0rld / amfora

A fancy terminal browser for the Gemini protocol.
GNU General Public License v3.0
1.16k stars 67 forks source link

ability to specify keys to highlight next/prev link #209

Closed howeyc closed 3 years ago

howeyc commented 3 years ago

any interest in adding someting like this?

I know there's likely more change required and perhaps this is not exactly the way it should be done, but perhaps it's a starting point?

I'm not sure how to replace the current dependency on the Tab key, or if that's desired.

howeyc commented 3 years ago

Oh, I see. So removing Tab, or assigning Tab to another command is not currently possible.

However, the change I made could allow for another configurable key to be assigned to next/prev link highlighting.

makew0rld commented 3 years ago

next/prev link highlighting

I'm confused what this is exactly. Your code uses the n and p keys, which currently aren't used in Amfora. To highlight the next and previous links I use Tab and Shift-Tab. What are you trying to add? I think that we don't need another key for this, just a way to re-assign Tab, which requires upstream changes.

howeyc commented 3 years ago

True. Fair enough.