makew0rld / amfora

A fancy terminal browser for the Gemini protocol.
GNU General Public License v3.0
1.16k stars 67 forks source link

Allow custom URL placement for external handlers #213

Closed t-900-a closed 2 months ago

t-900-a commented 3 years ago

Previously the URl was appended to the end now it can be placed anywhere using {{url}} https://github.com/makeworld-the-better-one/amfora/issues/212

t-900-a commented 3 years ago

Thanks for working on this! The main problem is that you've broken compatibility with older configs. Specifying a command without {{url}} should still work, and use the old behaviour.

Ok, I'll do a regex match for {{url}} if it's not found, then I'll append to the end as was done previously.

We'll look at this on the weekend

t-900-a commented 3 years ago

Thanks for working on this! The main problem is that you've broken compatibility with older configs. Specifying a command without {{url}} should still work, and use the old behaviour.

fixed

makew0rld commented 3 years ago

Thanks for updating! Two things:

makew0rld commented 3 years ago

@t-900-a any update on this?

makew0rld commented 2 months ago

Closing manually due to inactivity and lack of Amfora development.