Adding bindings to yank the current URL and the selected URL

makew0rld / amfora

A fancy terminal browser for the Gemini protocol.

GNU General Public License v3.0

1.16k stars 67 forks source link

Adding bindings to yank the current URL and the selected URL #225

Closed lostleonardo closed 3 years ago

lostleonardo commented 3 years ago

Many thanks for the excellent support regarding where to make the changes - and for developing a code base that allowed me to get something working with so little difficulty. :-)

I used the following clipboard library https://pkg.go.dev/github.com/atotto/clipboard?utm_source=godoc ... I don't think it needs cgo, although it does depend on xsel or xclip (and their equivalents on Windows and Mac OS). Hopefully that fits with what you were thinking.

Issue #220

singalhimanshu commented 3 years ago

I guess you should add bind_yank_page_uri and bind_yank_target_uri under https://github.com/makeworld-the-better-one/amfora/blob/fe35f45e8c337c8feb6fb21fd0abf7a744995dc8/config/default.go#L160 Otherwise ~/.config/amfora/config.toml won't have these options in default config.

lostleonardo commented 3 years ago

Thanks @singalhimanshu. Now added.

makew0rld commented 3 years ago

Looks great! I tested and it all works fine. Thanks!