makew0rld / amfora

A fancy terminal browser for the Gemini protocol.
GNU General Public License v3.0
1.16k stars 67 forks source link

Lists do not get rendered when bullets = false #234

Closed regr4 closed 3 years ago

regr4 commented 3 years ago

Hi, whenever my config.toml contains bullets = false, lists do not show up on screen, but when I have bullets = true, then they do show up. I'm using the latest git commit (a4a56a6..) via Homebrew on MacOS with iTerm2. My config.toml is almost exactly default-config.toml except for some color adjustments, and I've confirmed the problem using the default.

To replicate:

I couldn't find another issue about this, my apologies if this is a duplicate.

regr4 commented 3 years ago

I'm pretty sure the problem is in renderer.go at line 227: I don't know much about Go, but if I'm reading it correctly, if bullets is set to false, it just doesn't render the line. I will try to figure out whether this is the case tomorrow.

singalhimanshu commented 3 years ago

I'm pretty sure the problem is in renderer.go at line 227

Yeah you are correct that is where the bug is coming from. Let me know if you are working on this, else I can submit a PR to fix this.

regr4 commented 3 years ago

I have created a pull request that should fix this issue.

makew0rld commented 3 years ago

Ouch, sorry about this. You are correct. Will merge #235 ASAP.