makew0rld / amfora

A fancy terminal browser for the Gemini protocol.
GNU General Public License v3.0
1.14k stars 65 forks source link

Not using $XDG_CONFIG_HOME on Windows #255

Closed cpkio closed 2 years ago

cpkio commented 2 years ago

I have $XDG_CONFIG_HOME set in Windows (since I use Neovim daily). But Amfora seems to be ignoring it: expected to see Amfora config in my Neovim directory, but *.toml are in my $APPDATA\Roaming\amfora anyway.

Probably it would be better to provide a separate environment value for config path, so that Amfora could be made portable.

makew0rld commented 2 years ago

That's correct, Amfora only looks at that variable on *nix systems. I can change that though, I guess there's no harm.

I will get around to doing this, or would accept a PR.

makew0rld commented 2 years ago

Fixed, this will be in v1.9.0. Technically this could mess up some people's setups if they had this variable set but also had a custom config in the APPDATA folder. Also applies to bookmarks and subscriptions. But I suspect this is very rare, and the files aren't deleted anyway. It will be mentioned in the release notes.