search

makew0rld / amfora

A fancy terminal browser for the Gemini protocol.
GNU General Public License v3.0
1.16k stars 67 forks source link

add omni by day & by night themes #258

Closed omnivagant closed 1 year ago

omnivagant commented 3 years ago

I think the commented out values are the default ones, but it was some months since I did this. I could probably clean this up a bit, but I wanted to share.

Myself, I now use transparent terminals and background = "default".

makew0rld commented 3 years ago

Thanks for sharing. If you're able to clean this up that would be appreciated, you can see other themes as a reference. It would make maintenance much easier in the future.

makew0rld commented 2 years ago

@omnivagant are you planning on updating this? Changes will be required now since the Amfora default theme has changed. I suspect it will mostly just be uncommenting all your lines.

You also need to update the theme README with some information and a photo, see #251 or any other theme PR as an example.

makew0rld commented 2 years ago

@omnivagant looking at your latest commits:

To upload images, you can put them in this thread, then get the link from there.

For bg, just put the value that best fits your theme. Presumably it's #ffffff for day and #000000 for night.

Also, your theme is missing keys. Please define all the possible theme keys, as Amfora (v1.9.0 and later) will default to using the terminal theme for undefined keys.

For the future I prefer PR authors to not do force-pushes as it makes it hard to understand what was changed. I will squash the commits when merging anyway.

Thanks!

makew0rld commented 2 years ago

@omnivagant any update on this?

makew0rld commented 1 year ago

I'm going to close this, but feel free to open another PR taking my comments above into account.