search

makew0rld / amfora

A fancy terminal browser for the Gemini protocol.
GNU General Public License v3.0
1.16k stars 67 forks source link

Modal fixes (#281) #284

Closed awfulcooking closed 2 years ago

awfulcooking commented 2 years ago

Pushing commits to this branch, feel free to test / merge, or wait for more to come in.

makew0rld commented 2 years ago

Looking good, thanks for this! Let me know when you think it's done.

awfulcooking commented 2 years ago

I think we should merge this, test it, and release after a few days if all seems well. Then improve from there!

makew0rld commented 2 years ago

I'd rather test before merging, but in general this seems like a good fix for this issue, thanks for your work. As for a release, I gotta see, because I already have a new feature in master (#263), so to make a v1.9.3 release for #283 would require reverting the feature and re-adding it after release. #283 is not a show-stopper bug, so I'm not sure if it merits its own release or not.

Also please see my reply above.

makew0rld commented 2 years ago

As for testing, it would probably be best to induce errors, like was done in #281, and make sure there are no UI issues.

makew0rld commented 2 years ago

Going to merge this now, having done some testing myself. Thanks for making this patch. I don't intend to make a release for this, but it will be in v1.10.0 of course.

If you have an idea about my comment above that would be appreciated.