search

makew0rld / amfora

A fancy terminal browser for the Gemini protocol.
GNU General Public License v3.0
1.14k stars 68 forks source link

Consider shipping release tarball with vendored dependencies #296

Open illiliti opened 2 years ago

illiliti commented 2 years ago

For example, dnscrypt-proxy does this by simply maintaining vendor directory. You can also setup CI to vendor dependencies into release tarball without needing to keep vendor directory within repository. Here is the command that can be used for this: go mod vendor

With vendored dependencies, i can build amfora from source without internet connection by using this command: go build -mod=vendor

makew0rld commented 2 years ago

Good idea, thanks. I'll add this for the next release.

makew0rld commented 2 years ago

PR #299 is one attempt at adding this.

aabacchus commented 2 years ago

@makeworld-the-better-one has there been any progress on this? Thanks

makew0rld commented 2 years ago

Nope I haven't made progress on this. It's still something I'd like to do but not a high priority for me. I made a comment in #299, so if someone made a PR that addresses that comment, I might be able to merge it in.