search

makew0rld / amfora

A fancy terminal browser for the Gemini protocol.
GNU General Public License v3.0
1.14k stars 68 forks source link

Update go dependencies and require go 1.17 #336

Closed grisu48 closed 11 months ago

grisu48 commented 12 months ago

Require go 1.17 as needed by golang.org/x/sys/unix/syscall and update all go dependencies to current versions, which are not pinned.

Proposed fix for https://github.com/makew0rld/amfora/issues/335

makew0rld commented 12 months ago

Thanks for this fix. Please don't update cview as it may cause UI breaking changes. It's pinned to a specific commit on purpose. Please also check semantic versioning, for example termenv may have breaking changes as well according to the semantic versioning spec. Otherwise I will be happy to merge this.

grisu48 commented 11 months ago

Thanks for the review! I updated the PR accordingly.

cview had indeed breaking changes. For the other dependencies, I used the freshly build amfora binary and could not find any regressions in basic usage.

grisu48 commented 11 months ago

@makew0rld do those change address your concerns now?

makew0rld commented 11 months ago

Thanks!

grisu48 commented 11 months ago

Thanks to you :slightly_smiling_face: