Closed grisu48 closed 11 months ago
Thanks for this fix. Please don't update cview
as it may cause UI breaking changes. It's pinned to a specific commit on purpose. Please also check semantic versioning, for example termenv
may have breaking changes as well according to the semantic versioning spec. Otherwise I will be happy to merge this.
Thanks for the review! I updated the PR accordingly.
cview
had indeed breaking changes. For the other dependencies, I used the freshly build amfora
binary and could not find any regressions in basic usage.
@makew0rld do those change address your concerns now?
Thanks!
Thanks to you :slightly_smiling_face:
Require go 1.17 as needed by golang.org/x/sys/unix/syscall and update all go dependencies to current versions, which are not pinned.
Proposed fix for https://github.com/makew0rld/amfora/issues/335