search

makew0rld / amfora

A fancy terminal browser for the Gemini protocol.
GNU General Public License v3.0
1.17k stars 67 forks source link

Certificates support #349

Closed smoorg closed 2 months ago

smoorg commented 2 months ago

This change introduces breaking change of calling cmd to openssl.

That way I was able to achieve support for creating certificates and keys straight from amfora.

The intention was, once user gets invalid certificate code, amfora acts proactively and proposes to create the cert for that page on its own.

Concerns:

  1. This might break Windows build. I do not know much about how openssl is implemented on its part. I should probably prepare some additional patch or exclude it from that implementation.
  2. We need openssl dependency on package definition end.
makew0rld commented 2 months ago

Sorry but I am not interested in depending on OpenSSL, this should be possible to do fully with the high quality API the Go stdlib provides.

Also please note that Amfora is in maintenance mode and so I can't guarantee such a feature will ever be merged.

smoorg commented 2 months ago

I understand. I'll leave it on my fork then. I managed to make it work with crypto package so thanks for the feedback.