makew0rld / didder

An extensive, fast, and accurate command-line image dithering tool.
GNU General Public License v3.0
366 stars 10 forks source link

FrozenError error on MacOS install #11

Closed sliday closed 1 year ago

sliday commented 2 years ago

Hi there,

After I successfully tap into brew tap makeworld-the-better-one/tap

I get this error:

`brew install didder ==> Downloading https://github.com/makeworld-the-better-one/didder/archive/v1.1.0.tar.gz ==> Downloading from https://codeload.github.com/makeworld-the-better-one/didder/tar.gz/refs/tags/v1.1.0

O=

==> Installing didder from makeworld-the-better-one/tap Error: An exception occurred within a child process: FrozenError: can't modify frozen class`

I'm on macOS Monterey 12.6, Macbook Air M2

Please assist.

makew0rld commented 2 years ago

Sorry, unfortunately I'm not sure how to resolve this issue, and I don't have a mac to test on at the moment.

If anyone has a mac to reproduce this issue on feel free to comment here. If anyone is familiar with Homebrew the code for the homebrew install is here: https://github.com/makeworld-the-better-one/homebrew-tap/blob/master/Formula/didder.rb

makew0rld commented 1 year ago

Opened this issue with homebrew to try and figure things out.

gingerbeardman commented 1 year ago

I also hit this blocker.

Kneecrust commented 1 year ago

I've taken a look using CGT and gotten the following suggestion:

In your Homebrew code, the issue seems to be with the definition of the applications method within the install method. The applications method is defined within the install method, which is causing the error.

To resolve this issue, you should move the applications method outside of the install method.

How should I go about adjusting this and retrying the installation through homebrew?

I'd love to get this running on my Mac as I've thoroughly enjoyed it while on Windows :)

makew0rld commented 1 year ago

To resolve this issue, you should move the applications method outside of the install method.

Seems easy enough, I would appreciate you testing this.

How should I go about adjusting this and retrying the installation through homebrew?

You can try using brew edit to edit the formula you already tried to install. Otherwise you can download and edit the formula file, then install from that file with brew install --build-from-source ./didder.rb

Let me know if you can get something that works!

Kneecrust commented 1 year ago

To resolve this issue, you should move the applications method outside of the install method.

Seems easy enough, I would appreciate you testing this.

@makew0rld Yes! It's the least I can do in return for you providing this awesome tool!

How should I go about adjusting this and retrying the installation through homebrew?

You can try using brew edit to edit the formula you already tried to install. Otherwise you can download and edit the formula file, then install from that file with brew install --build-from-source ./didder.rb

Let me know if you can get something that works!

Ah, I had done that but not found the command to install from a local formula. Just did and the installation went through successfully!

image

Here's the adjusted formula 💪 didder.txt

Thanks for the quick feedback!

makew0rld commented 1 year ago

Thanks for testing! Looks like just moving the applications method as you mentioned. I've updated my tap. Can you uninstall didder, and try and install it from my tap now? You might have to rerun the brew tap command, I'm not sure.

If everything goes well I will close this issue.

Kneecrust commented 1 year ago

Hi @makew0rld! Uninstalled Didder, resynced your tap, and installed Didder once again using the brew install didder command and it went through successfully!

Glad to have this awesome app up and running and available to Mac users again! ❤️