makhidkarun / traveller_pyroute

Traveller trade route generator
MIT License
14 stars 5 forks source link

Handle missing/wonky star sizes #83

Closed CyberiaResurrection closed 12 months ago

CyberiaResurrection commented 1 year ago

As at the status quo, missing/wonky star sizes ended up heaved out the window.

Two specific cases (motivating this PR) I tripped over from the M1105 Travmap data (turned out they were the only ones in the M1105 data as at Nov 2023) are:

Wrenton 1901: G7 M4 V
Blaskon 2828: M5 IC

After checking with @inexorabletash , he agreed (presuming the QWERTY keyboard layout) that IC is most likely a typoed form of IV. For missing sizes, he agreed with my suggestion to play the odds and assume a star size of V.

The two motivating examples fall out after those changes as:

Wrenton 1901: G7 V M4 V
Blaskon 2828: M5 IV

These two particular cases have been fixed in Travmap, but I want to harden PyRoute against similar, undetected, cases, such as in other milieux, and future fat-fingers.

As such, I've also handled: