makinacorpus / DbToolsBundle

A PHP library to backup, restore and anonymize databases
https://dbtoolsbundle.readthedocs.io
MIT License
182 stars 15 forks source link

no-issue - Remove mysql 5.7 from dev.sh, this version is not supported #111

Closed SimonMellerin closed 8 months ago

pounard commented 8 months ago

MySQL 5.7 is still in use by many legacy projects, I'm for sure would be very happy to drop it, but I'm afraid we'd loose users over this.

pounard commented 8 months ago

OK I remember now (cf. our chat) MySQL 5.7 docker container has problems, which makes it non testable on my local environment, I have no idea why exactly. But if we restore this, we could at least run tests. My opinion is that if we manage to make the container work again, and tests passes, we should keep it, otherwise we could drop it.

SimonMellerin commented 8 months ago

There is still some problems with MySQL 5.7 for example:


1) MakinaCorpus\DbToolsBundle\Tests\Functional\Anonymizer\AnonymizatorTest::testMultipleAnonymizersAtOnce
Doctrine\DBAL\Exception\SyntaxErrorException: An exception occurred while executing a query: SQLSTATE[42000]: Syntax error or access violation: 1064 You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'IF NOT EXISTS ```_db_tools_seq_table_test_get```() RETURNS BIGINT
DETERMINISTIC
' at line 1

/var/www/vendor/doctrine/dbal/src/Driver/API/MySQL/ExceptionConverter.php:86
/var/www/vendor/doctrine/dbal/src/Connection.php:1943
/var/www/vendor/doctrine/dbal/src/Connection.php:1885
/var/www/vendor/doctrine/dbal/src/Connection.php:1213
/var/www/vendor/makinacorpus/query-builder/src/Bridge/Doctrine/DoctrineQueryBuilder.php:122
/var/www/vendor/makinacorpus/query-builder/src/Bridge/AbstractBridge.php:226
/var/www/src/Anonymization/Anonymizator.php:518
/var/www/src/Anonymization/Anonymizator.php:379
/var/www/tests/Functional/Anonymizer/AnonymizatorTest.php:95

Caused by
Doctrine\DBAL\Driver\PDO\Exception: SQLSTATE[42000]: Syntax error or access violation: 1064 You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'IF NOT EXISTS ```_db_tools_seq_table_test_get```() RETURNS BIGINT
DETERMINISTIC
' at line 1

/var/www/vendor/doctrine/dbal/src/Driver/PDO/Exception.php:28
/var/www/vendor/doctrine/dbal/src/Driver/PDO/Connection.php:39
/var/www/vendor/doctrine/dbal/src/Connection.php:1211
/var/www/vendor/makinacorpus/query-builder/src/Bridge/Doctrine/DoctrineQueryBuilder.php:122
/var/www/vendor/makinacorpus/query-builder/src/Bridge/AbstractBridge.php:226
/var/www/src/Anonymization/Anonymizator.php:518
/var/www/src/Anonymization/Anonymizator.php:379
/var/www/tests/Functional/Anonymizer/AnonymizatorTest.php:95

Caused by
PDOException: SQLSTATE[42000]: Syntax error or access violation: 1064 You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'IF NOT EXISTS ```_db_tools_seq_table_test_get```() RETURNS BIGINT
DETERMINISTIC
' at line 1

/var/www/vendor/doctrine/dbal/src/Driver/PDO/Connection.php:33
/var/www/vendor/doctrine/dbal/src/Connection.php:1211
/var/www/vendor/makinacorpus/query-builder/src/Bridge/Doctrine/DoctrineQueryBuilder.php:122
/var/www/vendor/makinacorpus/query-builder/src/Bridge/AbstractBridge.php:226
/var/www/src/Anonymization/Anonymizator.php:518
/var/www/src/Anonymization/Anonymizator.php:379
/var/www/tests/Functional/Anonymizer/AnonymizatorTest.php:95

I close this PR and will open an issue specific to MySQL5.7