search

makinacorpus / DbToolsBundle

A PHP library to backup, restore and anonymize databases
https://dbtoolsbundle.readthedocs.io
MIT License
181 stars 15 forks source link

feat: allow new doctrine dbal and orm versions #123

Closed shakaran closed 7 months ago

SimonMellerin commented 8 months ago

Hi thanks for your PR.

This update is not insignificant and will require us to perform a few tests before we can mark this version as compatible with the DbToolsBundle.

I will close this one for now as we are not yet ready.

On your side, did you tested the DbToolsBundle on a living project with Doctrine and DBAL 3 already ?

Cheers

shakaran commented 8 months ago

Could we at least keep a dev branch or unstable official for test all this with new releases? I am fixing all the deprecations notices with Symfony 7.0 and try to support this in all codebases of my clients with PHP 8.3

pounard commented 8 months ago

After some internal discussions, we are reopening this issue.

The risk with this dependency raise is that they probably will pull doctrine/dbal:^4.0 at some point, and both makinacorpus/query-builder and makinacorpus/db-tools-bundle are untested using it.

We need to prepare our CI and run some additional unit tests, in both projects, before being able to safely apply this version bump.

@shakaran thanks for the suggestion, I'll prepare a new makinacorpus/query-builder version with extensive testing on that side, then we'll come back to this PR.

shakaran commented 8 months ago

or the suggestion, I'll pre

Thanks for reconsidering. And sorry if I was a bit rude in the other reply or PR (if you read it later my other response) (I am working quick with a lot pressure in my shoulders for keep all this updated in a lot projects)

pounard commented 7 months ago

I opened https://github.com/makinacorpus/DbToolsBundle/issues/140 and will work on a new PR for this, thanks for reporting, I'm closing this PR.