Closed picturestone closed 5 months ago
@picturestone first thank you very much ! It looks good to me, although I'm looking it with my phone I can't do a thourough review right now. I'll do in the next few days. @SimonMellerin I'll wait for your approval as well!
Hello @picturestone !
We have currently a few other PR that are awaiting for this one to get in, because we'd like to pass your fix in the next point release.
So, I took the liberty of forking your own branch and add a commit with all the suggestions we were expecting from you, so we may proceed with the next release in the next few days.
You can see it there: #161. I'm closing this PR. Since I kept your commits in my own branch, you will be credited in the main repository.
Thank you very much again for the work, we appreciate it very much!
This MR makes the timeouts for the backup and restore processes configurable (related issue #102).
I've run the
./dev.sh checks
and./dev.sh test_all
commands as described in https://dbtoolsbundle.readthedocs.io/en/stable/contribute/guide.html and they run through, though some tests are incomplete or skipped. However, i've also run the same commands on the main branch and the same tests are skipped/incomplete on both main and my issue-102-configurable-timeouts branch. If the test executions were okay before, they are also okay now.