search

makinacorpus / Leaflet.FileLayer

Loads files locally (GeoJSON, KML, GPX) as layers using HTML5 File API
http://makinacorpus.github.io/Leaflet.FileLayer/
MIT License
270 stars 91 forks source link

FYI: forked and enhanced #8

Closed joeybaker closed 10 years ago

joeybaker commented 10 years ago

Just as an FYI, I need additional functionality, so I forked. The changelog is here: https://github.com/joeybaker/Leaflet.FileLayer#changelog

leplatrem commented 10 years ago

Thanks for letting me know !

I will definitely cherry-pick some of your commits ! Not all of them though, since I am really not a fan of prefixed commas and optional semi-colons (matter of taste) :)

joeybaker commented 10 years ago

Yup yup! I stuck with your style for a while, but eventually got to a point where it was different enough that I figured I'd be maintaining it on my own. If you're planning on keeping all the functionality though, i'd happily revert the style changes and submit a PR.

joeybaker commented 10 years ago

@leplatrem howdy – my fork has very significantly diverged from your code; I'm considering completely renaming not even pretending to be the same as you original (very cool) repo. Any objections/requests?

leplatrem commented 10 years ago

I wish I could catch up with your fork, time has passed and I didn't take time to do it...

Note that I would have accepted your pull-requests if you had opened them :) It's a pity to duplicate efforts, but I don't mind if you rename it !

Thanks for letting me know anyway :)

joeybaker commented 10 years ago

Fair! I'll make some time to send some PRs!

leplatrem commented 10 years ago

I merged some of your contributions, and added some tests with Mocha :)

I bumped to version 0.3, to prevent conflicts with your versions... just in case.