Switch source from tagged services to custom repository of entities

Nerobrain commented 7 years ago

Sorry for my bad english. Just try to use and extend your bundle.

pounard commented 7 years ago

Wow, thanks a lot for this!

There's a lot of interesting changes in there, but the pull request is too big, I'd like to have multiple but smaller issues to review.

I'll try to take some time to comment, can't do right now, but in the next few days I'll do a complete review.

pounard commented 6 years ago

Ok, it's been a long time, first of all, I have lots of notes about your changes:

why did you change so many method names ? It's wrong because breaks backward compatibility, and it's unnecessary because it pollutes the diff with useless changes,
you hardcode Doctrine dependency within this bundle, which is something I do not want, I actually do maintain Symfony project without doctrine,
for a Doctrine implementation, you should place it in a src/Bridge/Doctrine folder, and build a meaningful configuration for users (using the Configuration component and some magic to autoregister sources for components the user enabled).

That said, there's probably some nice modifications within your changes, but you should fix the rest first.

makinacorpus / autocomplete-bundle