makinacorpus / django-geojson

django-geojson is a collection of helpers to (de)serialize (Geo)Django objects into GeoJSON.
GNU Lesser General Public License v3.0
259 stars 69 forks source link

Support Django 3.2 #113

Closed adamchainz closed 3 years ago

adamchainz commented 3 years ago
adamchainz commented 3 years ago

I didn't check the tox file since I haven't done the spatialite setup locally.

I'd recommend having CI run tox - this way there won't be two grids that can get out of sync. See my package CI setup, e.g. https://github.com/adamchainz/django-htmx/blob/main/.github/workflows/main.yml

Gagaro commented 3 years ago

Thanks for the cleanup.

I'll set up Github Actions first before merging this PR. Thanks for the example, but I don't like not having a job for each environment (python version + django version).

I agree with you on duplicating the matrices though. I remember something doing a job per tox environment on travis and there seems to be something equivalent for gh actions (https://github.com/ymyzk/tox-gh-actions), I'll try that.

(Also, you should hide your coveralls token in your secrets).

adamchainz commented 3 years ago

Good shout, GH Actions is definitely better than Travis.

I used to use tox-gh-actions but dropped it because I felt it was unnecessary to add extra config. I do one job per Python version, with a shell one liner to select the relevant versions. Check out my open source projects for example: https://github.com/adamchainz/django-htmx/blob/main/.github/workflows/main.yml

Gagaro commented 3 years ago

I ended up copying the action from django-leaflet, it seems there are still tests failings but I need some of your fix for the last version.

adamchainz commented 3 years ago

Great, thanks.