search

makinacorpus / django-geojson

django-geojson is a collection of helpers to (de)serialize (Geo)Django objects into GeoJSON.
GNU Lesser General Public License v3.0
259 stars 69 forks source link

Fix encoding error in setup.py; Fix #83 and Fix #53 #90

Closed konstin closed 6 years ago

konstin commented 6 years ago

While pip install django-geojson works properly on my machine, but it suddenly fails when run inside of a docker container with the same ubuntu version.

Minimal Dockerfile for reference:

FROM ubuntu:17.04
RUN apt-get update
RUN apt-get install -y python3-pip
RUN pip3 install django-geojson
konstin commented 6 years ago

Update: The Problem only occurs when the locale is set to C, i.e. with export LANG=C. As most people have a different locale on their machines, this problem doesn't show for them. Docker apparently defaults to LANG=C and therefore fails. ENV LANG C.UTF-8 can work around this problem, but I'd stil propose this PR as proper fix. More information is available here and here

Gagaro commented 6 years ago

Thanks

Gagaro commented 6 years ago

This actually doesn't work with python2