search

makinacorpus / django-leaflet

Use Leaflet in your Django projects
GNU Lesser General Public License v3.0
717 stars 283 forks source link

Add docker to example project #378

Open ShmuelTreiger opened 5 months ago

ShmuelTreiger commented 5 months ago

I couldn't get the example project to run locally on my windows machine because of the GDAL dependancy. I created a docker container so that I could run the project. I've stripped it down to the bare minimum and put it in this PR. I thought this would be useful to include in light of #336, so others people could use it if they're also struggling.

claudep commented 5 months ago

The maintainer will decide, but I never saw docker files included in other 3rd-party Django apps.

ShmuelTreiger commented 5 months ago

That's fair. This was just really frustrating to get to work. Maybe better to just add docker instructions?

Gagaro commented 5 months ago

Thanks for the PR, though I agree with claudep, there isn't much sense in adding a Dockerfile in a Django app. Maybe this would be better located in the documentation?