search

makinacorpus / django-safedelete

Mask your objects instead of deleting them from your database.
https://django-safedelete.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
677 stars 122 forks source link

Add count return to delete and undelete methods #204

Closed GustavoNagel closed 2 years ago

GustavoNagel commented 2 years ago

Hello, there. This PR adds to delete and undelete methods the count of elements as it is with default delete method. I expect to be solving issue https://github.com/makinacorpus/django-safedelete/issues/173#issue-1028115171 that was classified as a bug. Thank you.

coveralls commented 2 years ago

Coverage Status

Coverage increased (+0.08%) to 97.255% when pulling db196a31885df9d0eecaf9ad27cab631e375a1b4 on GustavoNagel:master into c659ccf2b35cf32d6cddb57d8dec21fdbe7b1d52 on makinacorpus:master.

Gagaro commented 2 years ago

Thanks a lot for this PR!

LGTM and I feel like we can release it in 1.2.2 as we were not returning anything before.