search

makinacorpus / django-safedelete

Mask your objects instead of deleting them from your database.
https://django-safedelete.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
677 stars 122 forks source link

Add Hard Delete Action to SafeDeleteAdmin #236

Closed Xalph555 closed 1 year ago

Xalph555 commented 1 year ago

Adding a hard delete action to allow admins to permanently delete soft deleted records.

Function itself is near identical to the undelete_selected action but I am unsure whether we want to create another function, or functions, to extract the common behaviours.

Gagaro commented 1 year ago

Thanks for the PR :+1: .

Could you check and fix the flake8 errors.

With only two functions, this should be all right to duplicate the logic there.

Xalph555 commented 1 year ago

Fixed the Flake8 errors

Gagaro commented 1 year ago

Thanks, there's still one left: safedelete/admin.py:82:1: W293 blank line contains whitespace

Xalph555 commented 1 year ago

Sorry about that. Hopefully I got them all now.

Xalph555 commented 1 year ago

Added commit in attempt to fix the latest workflow errors

coveralls commented 1 year ago

Coverage Status

coverage: 96.779% (-0.09%) from 96.873% when pulling 52a78678d074226956b3c16977c5cacf0df76ef6 on Xalph555:Hard-Delete-Admin-Action into 6cdd3e8d079896d61efca22c6abe51f10ce26705 on makinacorpus:master.

Gagaro commented 1 year ago

Thanks again for the PR and the follow ups :ok_hand: .

jvdminne commented 11 months ago

I see that in the CHANGES file this one is mentioned for release 1.3.3, but as stated is not available as pip package yet. Is there any ETA on when this feature will be released? This is a feature that we would really like to implement in some of our projects.

Gagaro commented 10 months ago

Hi @jvdminne , I just released 1.3.3, enjoy :smiley: .

jvdminne commented 10 months ago

Awesome, thanks! I will try it asap.