search

makinj / MeNext

Media request service with a hint of democracy!
MIT License
9 stars 3 forks source link

the first of several security updates I will be making with my code r… #59

Closed makinj closed 7 years ago

makinj commented 7 years ago

…eview and all the things I have learned about sec

t3dotgg commented 7 years ago

Are you just adding a sanitize_inputs here?

makinj commented 7 years ago

Basically There was XSS I have a few other findings from last night, that was just all I could solve super quickly

makinj commented 7 years ago

I also got rid of a redirect that I wasn't able to exploit, but was more dangerous than the feature was worth It would redirect without the extra GET parameters that get sent with a fb oauth login But if there were some way to make the request with a script name that was a malicious URL (I don't think you can, but why risk it?) they might be able to make a link that looks like a MeNext URL but redirects somewhere bad.

t3dotgg commented 7 years ago

Awesome, didn't even think that removal was removing a security risk. Thanks for the update!